Skip to content

chore: migrate to qt tray for all platforms - #5260

Merged
ReenigneArcher merged 5 commits into
masterfrom
chore/migrate-to-qt-tray
Jul 29, 2026
Merged

chore: migrate to qt tray for all platforms#5260
ReenigneArcher merged 5 commits into
masterfrom
chore/migrate-to-qt-tray

Conversation

@ReenigneArcher

@ReenigneArcher ReenigneArcher commented Jun 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Description

Migrates to QT tray on all platforms. Do not merge until after has merged. LizardByte/tray#145 and released.

TODO:

  • Test windows standalone version
  • Test windows service version
  • Test macOS
  • Create release of tray library

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@codecov

codecov Bot commented Jun 7, 2026

Copy link
Copy Markdown

Bundle Report

Bundle size has no change ✅

@ReenigneArcher
ReenigneArcher force-pushed the chore/migrate-to-qt-tray branch 5 times, most recently from 0a970e1 to 2d4b05e Compare June 7, 2026 03:20
@ReenigneArcher ReenigneArcher mentioned this pull request Jun 7, 2026
Merged
21 tasks
@ReenigneArcher
ReenigneArcher force-pushed the chore/migrate-to-qt-tray branch 2 times, most recently from f6f0e67 to 4fe76cc Compare June 7, 2026 17:16
@codecov

codecov Bot commented Jun 7, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 27.36%. Comparing base (e2074c6) to head (1055f15).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #5260     +/-   ##
=========================================
  Coverage   27.36%   27.36%             
=========================================
  Files         109      109             
  Lines       24658    24658             
  Branches    10875    10875             
=========================================
+ Hits         6747     6748      +1     
- Misses      14997    16124   +1127     
+ Partials     2914     1786   -1128
Flag Coverage Δ
Archlinux 0.00% <ø> (ø)
FreeBSD-amd64 13.74% <ø> (+0.02%) ⬆️
Homebrew-macos-14 21.37% <ø> (ø)
Homebrew-macos-15 22.04% <ø> (+<0.01%) ⬆️
Homebrew-macos-26 22.17% <ø> (+0.01%) ⬆️
Homebrew-ubuntu-24.04 13.35% <ø> (ø)
Linux-AppImage 12.66% <ø> (ø)
Windows-AMD64 16.36% <ø> (ø)
Windows-ARM64 14.20% <ø> (ø)
macOS-arm64 18.70% <ø> (ø)
macOS-x86_64 19.41% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 31 files with indirect coverage changes

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2074c6...1055f15. Read the comment docs.

@Kishi85

This comment was marked as resolved.

Sign in to view
@ReenigneArcher

This comment was marked as resolved.

Sign in to view
@ReenigneArcher ReenigneArcher mentioned this pull request Jun 28, 2026
Merged
21 tasks
@ReenigneArcher
ReenigneArcher force-pushed the chore/migrate-to-qt-tray branch 3 times, most recently from 2355ada to 6aa0caf Compare July 27, 2026 22:59
@LizardByte LizardByte deleted a comment from sonarqubecloud Bot Jul 28, 2026
@ReenigneArcher
ReenigneArcher marked this pull request as ready for review July 28, 2026 00:16
@ReenigneArcher
ReenigneArcher force-pushed the chore/migrate-to-qt-tray branch 3 times, most recently from 6c22a03 to 23d153f Compare July 28, 2026 12:13
@ReenigneArcher
ReenigneArcher force-pushed the chore/migrate-to-qt-tray branch from 23d153f to 1055f15 Compare July 29, 2026 00:03
@sonarqubecloud

sonarqubecloud Bot commented Jul 29, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ReenigneArcher
ReenigneArcher merged commit 089f15d into master Jul 29, 2026
69 checks passed
@ReenigneArcher
ReenigneArcher deleted the chore/migrate-to-qt-tray branch July 29, 2026 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ReenigneArcher @Kishi85